Open
Conversation
… so that it'd be uniform for rake
…or start and end dates
….rb for added clarity
… classes and tests as a result
…rooms and views a list of rooms that aren't reserved for a given range
…d access_reservation method to remove strftime(%Y-%m-%d) functionality
…lib/hotel_admin.rb
…om method in hotel class.rb
| def add_reservation(reservation) | ||
| #note: this is tightly coupled, I think. | ||
| @reservations << reservation | ||
| @reservation = reservation |
There was a problem hiding this comment.
Why set this as an instance variable here?
| end | ||
|
|
||
| def calc_reservations(reservation) | ||
| reservation.price_night * reservation.calc_duration |
There was a problem hiding this comment.
I think this logic would be better inside the reservation object
|
|
||
| def create_block(input) | ||
|
|
||
| if input[:block_start_date] == nil || input[:block_end_date] == nil |
There was a problem hiding this comment.
All of this data validation should be in an initialize somewhere
HotelWhat We're Looking For
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotel
Congratulations! You're submitting your assignment!
Comprehension Questions